Update create_deployment notebook #239

djkonro · 2017-06-03T17:11:34Z

No description provided.

k8s-ci-robot · 2017-06-03T17:11:36Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

djkonro · 2017-06-03T17:34:47Z

/retest

pokoli · 2017-06-05T14:29:48Z

examples/notebooks/create_deployment.ipynb

   "metadata": {
    "collapsed": true
   },
   "outputs": [],
   "source": [
-    "client.Configuration().host=\"http://localhost:8080\""
+    "config.load_kube_config()\n",
+    "extensions = client.ExtensionsV1beta1Api()"


I also changed this line in:

https://github.com/kubernetes-incubator/client-python/pull/242/files

I think it's better to load incluster config as the examples are intended to be run from inside a kubernetes cluster.

@pokoli do you mind if we merge this PR and close yours. This addresses more issues in the notebook. Once merged we can discuss more.

The general issue with these notebooks is to figure out a way to quickly test them.

I am tempted to add two steps in the notebooks with a try loop that loads in cluster and loads out of cluster.

@mbohlool I am +1 on this, we need to improve things but it is a first step

Makes sense to merge my PR into this. When I first created my PR I wasn't aware of this. So please go ahead.

sebgoa · 2017-06-07T12:01:06Z

examples/notebooks/create_deployment.ipynb

   "metadata": {
    "collapsed": true
   },
   "outputs": [],
   "source": [
-    "client.Configuration().host=\"http://localhost:8080\""
+    "config.load_kube_config()\n",
+    "extensions = client.ExtensionsV1beta1Api()"


@pokoli do you mind if we merge this PR and close yours. This addresses more issues in the notebook. Once merged we can discuss more.

The general issue with these notebooks is to figure out a way to quickly test them.

I am tempted to add two steps in the notebooks with a try loop that loads in cluster and loads out of cluster.

sebgoa · 2017-06-07T12:01:34Z

examples/notebooks/create_deployment.ipynb

   "metadata": {
    "collapsed": true
   },
   "outputs": [],
   "source": [
-    "client.Configuration().host=\"http://localhost:8080\""
+    "config.load_kube_config()\n",
+    "extensions = client.ExtensionsV1beta1Api()"


@mbohlool I am +1 on this, we need to improve things but it is a first step

sebgoa · 2017-06-07T12:12:47Z

examples/notebooks/create_deployment.ipynb

   "metadata": {
    "collapsed": true
   },
   "outputs": [],
   "source": [
-    "extensions = client.ExtensionsV1beta1Api()"
+    "deployment = client.models.extensions_v1beta1_deployment.ExtensionsV1beta1Deployment()"


@djkonro actually you should change this to deployment = client.ExtensionsV1beta1Deployment()

djkonro · 2017-06-08T10:14:12Z

examples/notebooks/create_deployment.ipynb

+   },
+   "outputs": [],
+   "source": [
+    "#extensions.delete_namespaced_deployment(name='nginx-deployment', namespace='default', body=client.V1DeleteOptions(),grace_period_seconds = 56, propagation_policy =  \"Background\")"


@mbohlool, Please I would like to get some help with this, as I am unable to achieve cascading deletion. Only the deployment is deleted and the dependent pods still stay alive.

Search issues for this. I think somebody had the same problem recently and we discussed it there. Briefly, I think there is a bug upstream (in k8s itself) and you need to delete childs one by one.

I don't think it is a bug. The kubectl delete deployment has a reapper that cascades deletion to pods, but the delete deployment API call itself does not do that.

@djkonro you can list pods with the label of the deployment and delete them based on that.

ref: #162

Look like with 2.0.0, you should be able to do cascade delete?

@mbohlool, I have tried various options but it does not seem to delete dependents, even when I set propagationPolicy to Background or Foreground, like in the function call below.
extensions.delete_namespaced_deployment(name='nginx-deployment', namespace='default', body=client.V1DeleteOptions(),grace_period_seconds = 56, propagation_policy = \"Background\")

Even the grace_period_second does not seem to take effect.

@sebgoa The pods are a part of a ReplicaSet, so they automatically get recreated when I delete them. I usually just tend to deleted the ReplicaSet in order to delete the pods, but I am looking for a better solution where I can delete them directly from the deployment.

Thanks to @vascofg, updating my version of Kubernetes solved my cascading deletion issue. @mbohlool, thanks for the link to #162

djkonro · 2017-06-19T13:04:53Z

@sebgoa, I have added RollingUpdate and RollBack to the deployment notebook, as seen in https://kubernetes.io/docs/concepts/workloads/controllers/deployment/. Please let me know what you think.

sebgoa · 2017-06-29T10:12:56Z

@djkonro there is no rolling update or rollback, I think you forgot to push the commit.

djkonro · 2017-06-29T20:46:03Z

@sebgoa Thanks for noticing the omission, sorry I did not realize the commit did not contain rolling update or rollback.

sebgoa · 2017-07-07T10:33:49Z

/lgtm

@mbohlool

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 3, 2017

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 3, 2017

mbohlool requested a review from sebgoa June 4, 2017 07:18

pokoli reviewed Jun 5, 2017

View reviewed changes

sebgoa approved these changes Jun 7, 2017

View reviewed changes

sebgoa mentioned this pull request Jun 7, 2017

Use load_incluster_config in jupyther notebook examples #242

Closed

sebgoa suggested changes Jun 7, 2017

View reviewed changes

djkonro force-pushed the master branch 3 times, most recently from 286051a to 55676fa Compare June 7, 2017 17:21

djkonro commented Jun 8, 2017

View reviewed changes

djkonro force-pushed the master branch 4 times, most recently from 0c12ce2 to 9a837ee Compare June 13, 2017 18:50

djkonro force-pushed the master branch 2 times, most recently from 7c9439a to 96488f1 Compare June 19, 2017 12:56

djkonro force-pushed the master branch from 96488f1 to 55676fa Compare June 19, 2017 23:28

djkonro mentioned this pull request Jun 29, 2017

Create Jupyter notebooks for common operations #127

Closed

djkonro force-pushed the master branch from 55676fa to a33230a Compare June 29, 2017 20:42

djkonro force-pushed the master branch 4 times, most recently from 55676fa to 04ef076 Compare July 6, 2017 02:10

Update create_deployment notebook

7d98dcc

djkonro force-pushed the master branch 3 times, most recently from 55676fa to 7d98dcc Compare July 6, 2017 21:12

mbohlool merged commit 9ba5378 into kubernetes-client:master Jul 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update create_deployment notebook #239

Update create_deployment notebook #239

djkonro commented Jun 3, 2017

k8s-ci-robot commented Jun 3, 2017

djkonro commented Jun 3, 2017

pokoli Jun 5, 2017

sebgoa Jun 7, 2017

sebgoa Jun 7, 2017

pokoli Jun 7, 2017

sebgoa Jun 7, 2017

sebgoa Jun 7, 2017

sebgoa Jun 7, 2017

djkonro Jun 8, 2017

mbohlool Jun 8, 2017

sebgoa Jun 9, 2017

mbohlool Jun 9, 2017

djkonro Jun 10, 2017

djkonro Jun 10, 2017

djkonro Jun 10, 2017

djkonro Jun 13, 2017 •

edited

Loading

djkonro commented Jun 19, 2017

sebgoa commented Jun 29, 2017

djkonro commented Jun 29, 2017

sebgoa commented Jul 7, 2017

Update create_deployment notebook #239

Update create_deployment notebook #239

Conversation

djkonro commented Jun 3, 2017

k8s-ci-robot commented Jun 3, 2017

djkonro commented Jun 3, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djkonro Jun 13, 2017 • edited Loading

Choose a reason for hiding this comment

djkonro commented Jun 19, 2017

sebgoa commented Jun 29, 2017

djkonro commented Jun 29, 2017

sebgoa commented Jul 7, 2017

djkonro Jun 13, 2017 •

edited

Loading